Remove unsafe transmute of should_interrupt #1154
Closed
+52
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurer
force-pushed
the
remove-unsafe
branch
3 times, most recently
from
6c42a50 to
b713bed
Compare
Adds a lifetime to the ExtendedBufRead trait to specify how long the callback provided must live.
martinvonz
approved these changes
Dec 6, 2023
Byron
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks so much!
The description of the transmute already makes clear how I struggled to make this work, and for some reason adding a lifetime is nothing I managed to do.
It's also great to see that I was awfully wrong thinking that this cannot currently be expressed, and that ultimately the solution was quite simple and definitely for the better.
|
Closing, as this was merged with the commit rewritten as 88f8b34 , I needed the commit message to declare that this is a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lifetime to the
ExtendedBufReadtrait to specify how long the callback provided must live.cc @Manishearth